olfek
olfek
@penge What do you think?
> As it wasn't designed for full regular expressions, this change isn't a breaking change and doesn't require an apology. I meant **_IF_** you removed the `replace` calls, it would...
@penge 👌
@penge https://github.com/penge/block-site/blob/00d340a493a77603d40cfd01576f438676a12d55/src/helpers/find-rule.ts#L19-L43 https://github.com/penge/block-site/blob/00d340a493a77603d40cfd01576f438676a12d55/src/helpers/make-rules.ts#L10-L23 - The input regex should not be modified in anyway (no `replace` or `removeProtocol`). - Regex should be matched against the original `url` (including protocol) and not...
This feature will certainly make this application very powerful.
I'm thinking if a rule tester should go out with this feature, regex is sometimes quite tricky to get right.
@penge I was thinking something simple like this  RED = **will** block GREEN = will **not** block
@penge > Maybe the colors meaning could be more broader: > **RED** = No match (either doesn't block or doesn't exclude) > **GREEN** = Match (either blocks or excludes) This...
@penge Whatever color you decide to go with, I think you should have a key that states what each color means 🙂
https://www.allaboutvision.com/en-gb/conditions/color-blindness/red-green-color-blindness/