Leonardo L.

Results 53 comments of Leonardo L.

> @ValuedMammal Please let me know what are your thoughts on these changes. I did remove the updates where it's `pub(crate)` APIs, and kept only the ones for explicitly `pub`...

> [...] > > -- > > edit: @oleonardolima Just checking, is the plan to go ahead and complete #1432 in this PR? I think I can continue the work...

> Thanks for working on this. There's a small typo in the changelog notice - `FeePolicy::fee_absolute` should say `TxBuilder::fee_absolute`. Oh, thanks! Sorry for the oversight, fixed it.

> ACK [5f2d6cb](https://github.com/bitcoindevkit/bdk/commit/5f2d6cbf08106028558dda570a28de50690496d5) > > I made one small suggestion and I think you need to do a rebase. Otherwise looks ready to merge to me. **EDIT:** I applied the...

@notmandatory I think this one is missing the [`1.0.0-alpha`](https://github.com/bitcoindevkit/bdk/milestone/42) label, as it was on the #860, could you add to it, please ?

I'm willing to give a try on this one.

> Thanks `@oleonardolima` you'll need to keep an eye to see when rust-miniscript and rust-bitcoincore-rpc are ready. Feel free to start making PRs for any of the crate that only...

**update:** Some of the rust-bitcoin crates have been released, and the `rust-electrum-client`, and `electrsd` are ready to review (depends on each other). - [x] [rust-miniscript](https://github.com/rust-bitcoin/rust-miniscript) - [x] [rust-bitcoincore-rpc](https://github.com/rust-bitcoin/rust-bitcoincore-rpc) - [x]...

**NOTE:** it's not done yet, only consider it done after #1448, mistakenly marked as completed probably because my comment `partially fixes ...` at other PR 😅

Concept ACK, thanks for the suggestions!