oleibman

Results 474 comments of oleibman

Paragraph border colors need a little more attention. In Writer/RTF/Part/Header around line 470: ```php if ($style instanceof Numbering) { $this->registerList($this->listTable, $style, $defaultFont); } ``` You need to add: ```php if...

You are correct that PreserveText isn't absolutely required, but it can make things a lot simpler. ```php $footer->addPreserveText('Page {PAGE} of {NUMPAGES}'); ``` is much easier than adding a TextRun consisting...

I have mentioned this in the other ticket, and I hate to pile on, but, nothing has been working, not even a simple attempt to view coveralls.io, for at least...

I am still evaluating whether this is a good idea or not. Will it work if you add or remove a row or a column on the sheet? Add a...

Thank you for adding the tests. Comments are, alas, not completely independent from drawings. It's why I asked the question. Create a new spreadsheet with a comment. Notice that there...

It is not absolutely required that Coveralls doesn't report a decrease. However, we strive to eliminate that situation if possible, especially in code which is new in a change. In...

Thank you - success on both fronts - no problems with unit tests, and no missed statements.

I am probably interested in merging this. I do not have a timeline in mind, but I imagine it could happen before year-end. It is complicated, and I need to...

In issue #4037, there is a spreadsheet attached: https://github.com/PHPOffice/PhpSpreadsheet/files/15400250/merge.excel.xlsx It has a photograph, a textbox, a drawing of glasses, and a blue shape. When I load and save that with...

Another solution might be to pass through the SVG file as a drawing, in the same manner as you are passing through other files. This is just a thought off...