d2rmm icon indicating copy to clipboard operation
d2rmm copied to clipboard

Feature request: more powerful sections

Open Caedendi opened this issue 3 months ago • 8 comments

Hi Oleg,

You previously implemented my request to add a way to enable/disable all settings in a section (thanks again for that). I have since spent a lot of time tinkering with sections and various kinds of settings in the past year while developing v4 of my extended filter and have found that the current implementation is imperfect and not ideal. I want to suggest a simpler and more powerful solution.

My proposal: let sections simultaneously act as a value

Instead of the section reading its contents and automatically doing something special itself when it only contains checkboxes, I suggest removing that functionality and replacing it with functionality where a section simply can optionally also be a value itself.

Checkboxes: the obvious one

The most obvious one of course would be the checkbox. Just it being a simple checkbox would give modders total freedom in code behavior and in conjunction with the existing setting visibility toggling provides an easy and intuitive solution for both modders and users.

But don't limit it to only checkboxes

Regarding other section value types, I can think of a situation in my extended filter where I would like a section to also act like a dropdown list instead (it's for the Loot Filter => Stats & Modifiers => Show Equipment Quality section). Just don't limit the value types a section can contain (instead of course, another section), let modders have total freedom in creativity and be surprised with what they come up with.

Issue with the current implementation

Currently, if a section contains only checkboxes, you have provided an interactable checkbox inside the section element to toggle all of 'em at once. If these checkboxes are all enabled by default however, the section toggle itself still shows as disabled by default and clicking it will enable the toggle and disable all containing checkboxes (correctly). It functions like it should from a logical/programming viewpoint but it looks weird. And then there's the mixed scenario where one checkbox is enabled by default and one is disabled... I wouldn't want to think of a solution for that from a user viewpoint. This will be a non-issue with the above proposal.

Please expand visibility toggling to sections too

On a last note, I'd love it if the visibility feature could also be expanded to sections. If a section should not be visible, please hide the element and all its contents. Don't do anything else; that's the modder's responsibility. Maybe description could be added too, either inside the element or below it when expanded.

Would love to hear what you think about all of this.

Caedendi avatar Nov 29 '24 13:11 Caedendi