CoreBitcoin icon indicating copy to clipboard operation
CoreBitcoin copied to clipboard
verified publisher icon oleganza

Minor warning fix, and improvement to transaction signing API

Open BadPirate opened this issue 7 years ago • 3 comments

Found it necessary to sign a transaction that wasn't generated using the builder. Moved the transaction input signing functionality into BTCTransaction and exposed it there.

Tested: Downloaded an unsigned transaction from coinb.in -- Signed it with my own private key -- Verified transaction was now signed correctly.

BadPirate avatar Jan 24 '18 19:01 BadPirate

Can you add a code example please? I have exactly the same workflow

caffeinum avatar Oct 30 '18 18:10 caffeinum

@caffeinum - If you pull this version you should be able to call the private method from wherever you need and pass in the values rather than a top level object.

BadPirate avatar Oct 30 '18 21:10 BadPirate

In case somebody stumbles upon this thread and is interested in the case, I implemented this differently: https://github.com/flightwallet/ios/blob/master/flight.wallet/Wallet/BitcoinWallet.swift#L276

caffeinum avatar Nov 24 '18 21:11 caffeinum