FoundationPress

FoundationPress copied to clipboard

npm ERR! A complete log of this run can be found in:

3

**How can this bug be reproduced?** 1. Step one 2. Step two 3. Step three **What did you expect to happen?** **What happened instead?** **Please List the Following:** * OS...

hassan184

This PR is a much simpler approach to resolving https://github.com/olefredrik/FoundationPress/issues/1371 This PR has the following changes: - Support for added `aria-current='page'` attribute on current pagination. (line 34) - Removes orphaned...

strikemike2k

Cleanup Navigation

3

FoundationPress includes a bunch of navigation styling in the navigation.scss This is special styling without any documentation. (Which causes problems for users using FoundationPress for the first time #1364) FoundationPress...

derweili

editor.scss makes first line of blocks' text difficult to select/edit with the mouse

1

FoundationPress interferes with Gutenberg editor in a way that makes it hard to select/edit the first line of text with the mouse in a (paragraph/list) block. When I comment "@include...

aperitero

Npm install error " pathspec '4.0' "

6

runing **npm install** returns **error**: ``` Unhandled rejection Error: Command failed: C:\Program Files\Git\mingw64\bin\git.EXE checkout 4.0 error: pathspec '4.0' ``` **fix** that worked for me: update package.json line 42 from `"gulp":...

DeiCha

FdnPress 2.10.4 WP 5.1 Hosted on WPengine I have been wrestling with very weird image behavior on this install. Client reported 'distorted' images after embedding, and sent screenshots. I couldn't...

adambundy

Update start_lvl() function to match current WordPress?

4

The `start_lvl()` function in [`Foundationpress_Mobile_Walker`](https://github.com/olefredrik/FoundationPress/blob/master/library/class-foundationpress-mobile-walker.php) class replaces the public function `start_lvl()` the WordPress class `Walker_Nav_Menu`, right? Looking at the [current `Walker_Nav_Menu` in WordPress 4.9.2](https://core.trac.wordpress.org/browser/tags/4.9.2/src//wp-includes/class-walker-nav-menu.php#L0) it seems like there has been...

Aetles

Rename page-templates to templates, or template-parts to page-template-parts

2

I notice that in large projects, the src folder is sitting in between page-templates and template parts. Given the src assets can have a lot of sub folders and files...

kLOsk

Proper Documentation

8

I think FoundationPress is at a point where we should move away from using README for documentation and have a dedicated site/page for it. Here are some ideas: 1. We...

colin-marshall

Add PULL_REQUEST_TEMPLATE.md & CONTRIBUTING.md files

2

@Aetles made some great points regarding documentation of commits in https://github.com/olefredrik/FoundationPress/issues/1123#issuecomment-341810747. I think one thing that would help improve this is to add `.github/PULL_REQUEST_TEMPLATE.md` with some basic info requirements for...

colin-marshall