digitalgarden icon indicating copy to clipboard operation
digitalgarden copied to clipboard

Rudimentary way to link to files.

Open Mogyula opened this issue 1 year ago • 2 comments

Hi!

This is my very first pull request sent to any project ever; I hope this is how it works. :)

So it was when I deployed a Digital Garden based on an Obsidian vault that references a ton of locally saved PDFs (as to support ideation for a reasearch project) that I realized that these wouldn't work online, as the plugin wouldn't commit ordinary files, only notes and images I guess.

Now I didn't do any work on the plugin, but I came to realize that if I just commit those PDFs manually, and also apply these changes to the codebase, then they'd be accessible.

The change on the regexp in .eleventy.js:160 is to cosnider links with or without the pipeline symbol, because I've noticed that notes' links get converted to the labeled format as in [[Another page|Another page]] even if in Obsidian it was just [[Another page]]. With PDFs though, you get [[dummy.pdf]] without the pipe.

See this site for a demo.

Gyula

Mogyula avatar Apr 08 '23 13:04 Mogyula

Very cool, congrats on your first PR! I'll have a look over it some time this week.

oleeskild avatar Apr 11 '23 10:04 oleeskild

Sorry on my part as well for getting back to this with such a delay. I believe the requested changes have been made. Let me know otherwise.

Mogyula avatar Jun 10 '23 20:06 Mogyula