go-starter-kit icon indicating copy to clipboard operation
go-starter-kit copied to clipboard

Issue: 87 Adding gzip support for all requests

Open Rushit opened this issue 8 years ago • 3 comments

This will add support for gzip to address - https://github.com/olebedev/go-starter-kit/issues/87

@olebedev

Rushit avatar Jun 07 '17 21:06 Rushit

Hi @Rushit, thanks for the contribution! Did you see that tests have failed? It seems we have to make test passing, anyway.

olebedev avatar Jun 08 '17 04:06 olebedev

@olebedev I will fix the tests on this PR.

Rushit avatar Jun 08 '17 16:06 Rushit

Thanks man! I eventually got gzip working with echo's gzip middleware, but to do that I had to move bundle.js away from the binary.

Is there any reason from performance point of view to keep bundle.js in bindata?

iKonrad avatar Jun 08 '17 16:06 iKonrad