duk_config.h increase RECLIMITs

[linuxion]

Hi, @olebedev

As described in this PR when geth calls JsonEncode function from your library it fails in case of reaching the DUK_USE_JSON_ENC_RECLIMIT = 1000.

So what is the purpose of setting the reclimits of 1000? Are there any risks in increasing them?

Thank you!

[olebedev]

Hi @linuxion,

I think we have to ask @svaarala what was the purpose of it.

[svaarala]

There's no risk if the platform provides enough stack. The default limit is a compromise so that on most platforms the limit is reached before one actually runs out of stack (which often leads to a segfault or "abort").

So depending on the platform, one would first ensure there's enough stack if the platform default is too low, and then use Duktape normally with the RECLIMIT increased.

[linuxion]

Thank you @svaarala,

@olebedev what are you going to do with this? The issue is that your library is vendored in go-ethereum so devs can't just change the code.

[olebedev]

What platforms do you target with go-ethereum?

[karalabe]

Duktape is only used for transaction tracing, so it currently is only used on fairly beefy machines.

Would it be possible somehow to have this configurable via Go, so that you wouldn't need to bump the limits for everybody but still allow "power users" to run with higher limits without having to fork?

[holiman]

Any update on this? We would prefer to be able to use a vendored dependency of duktape instead of other hacks around it.

[bulgakovk]

Would also love If that could be reviewed and merged

[bulgakovk]

Hey any update on this?

[peterwillcn]

duk_logging.c: In function ‘duk__logger_prototype_log_shared’:
duk_logging.c:184:64: warning: ‘Z’ directive writing 1 byte into a region of size between 0 and 9 [-Wformat-overflow=]
  184 |  sprintf((char *) date_buf, "%04d-%02d-%02dT%02d:%02d:%02d.%03dZ",
      |                                                                ^
In file included from /usr/include/stdio.h:867,
                 from duk_logging.c:5:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output between 25 and 85 bytes into a destination of size 32
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[tanmaster]

Any update on this?