oldschoolbot
oldschoolbot copied to clipboard
Wildy slayer
Wildy slayer:
Changes:
- Added Krystilia
- Added larran's keys
- Added slayers enchantment's
- Added revs drop rates on task
- Add ability to extend revs
- Ensured you cant get catacombs drops during a wildy task
- Added seperate slayer task streak for wildy slayer, checked Turael skipping resets the correct streaks
- Added ring of wealth (i)
- Added pkChance to monsters during a wildy task
- Added pkChance to Scorpia, Chaos Elemental, Chaos Fanatic and Crazy Archaeologist
- Added Dagon'hai to Slayer CL
- Added 100% drop rate to larran's keys from superiors
- Added I Wildy More Slayer unlock
- Added a boolean to /k to allow kill trips in the wilderness off task (for boosted clue rates with row)
- Added barraging to normal jellies if in the wilderness
@gc I'm completely fine if this isn't done in a way that works for you, this was just a personal fun project mainly with seeing how much I could do with it. Open to changing and moving anything into different PRs if that makes it easier for you.
Apply Sweep Rules to your PR?
- [ ] Apply: Leftover TODOs in the code should be handled.
- [ ] Apply: All new business logic should have corresponding unit tests in the tests/ directory.
- [ ] Apply: Any clearly inefficient or repeated code should be optimized or refactored.
I don't really see much issues with the PR.
- Integration tests, even just 1 or 2, would be a big help in ensuring certain wildy slayer things never break or get bugged. You don't have to add them for me to merge this PR, but its worth the time. You can ask me for help with creating integration tests if you need. They are really not hard to do.
- Apart from that, the main important things to me to hear is: everything mostly matches osrs, and that users have tested it and everything they reported has been fixed/addressed, or if not, let me know.
Appreciate the feedback, not really sure how to do the integration tests, so would like your help or you to handle them.
The death rates are quite low currently and a bit cautious what to do with them as i believe the numbers were based off this pr - https://github.com/oldschoolgg/oldschoolbot/pull/5429
Testing has seemed fine so far, although you might want to get testers to test yourself and pass me back the feedback, you seem to get more testing attention than myself.
We will test (with me pinging and asking for testing and offering rewards) again, and then (assuming no issues) merge
Hey @ellipsis, give me a code review (just trying something ignore this)
Hey @ellipsis, give me a code review (just trying something ignore this)
OK! Reviewing this PR...
Responding to this comment by @gc. For more information about Ellipsis, check the documentation.