oldschoolbot icon indicating copy to clipboard operation
oldschoolbot copied to clipboard

adjust expire time shootingstar

Open Lajnux opened this issue 2 years ago • 4 comments

Description:

Adjusted the expire length slightly and made it also scale for patron tiers to be more reasonable.

Changes:

Adjusted the expire length slightly and made it also scale for patron tiers to be more reasonable.

Other checks:

  • [x] I have tested all my changes thoroughly.

Lajnux avatar Sep 26 '22 15:09 Lajnux

Since shooting stars are AFK, why not make them 2x max trip length like other 'AFK' stuff such as alching + cannonballs?

themrrobert avatar Sep 27 '22 04:09 themrrobert

Since shooting stars are AFK, why not make them 2x max trip length like other 'AFK' stuff such as alching + cannonballs?

I didn't think about that tbh, and it's doable but would be slight spaghetti code in the determineMineFunction

Lajnux avatar Sep 27 '22 09:09 Lajnux

Since shooting stars are AFK, why not make them 2x max trip length like other 'AFK' stuff such as alching + cannonballs?

I didn't think about that tbh, and it's doable but would be slight spaghetti code in the determineMineFunction

I would just take whatever determineMineFunction returns and multiply it by 2.

However idk if people would even want to spend that much time at a shooting star 🤷

themrrobert avatar Sep 27 '22 10:09 themrrobert

Since shooting stars are AFK, why not make them 2x max trip length like other 'AFK' stuff such as alching + cannonballs?

I didn't think about that tbh, and it's doable but would be slight spaghetti code in the determineMineFunction

I would just take whatever determineMineFunction returns and multiply it by 2.

However idk if people would even want to spend that much time at a shooting star 🤷

Yea then we would have to double the output, but it wouldn't really be accurate doing that since shooting stars have layers and then the outcome would kinda screw with the whole layer simulation. I think it's fine as is but the expire length def needs this slight length increase.

Lajnux avatar Sep 27 '22 12:09 Lajnux

I approve these changes as-is

themrrobert avatar Oct 10 '22 06:10 themrrobert