oldschoolbot
oldschoolbot copied to clipboard
oldschoolgg
Bso smithing boosts
As per the wiki, added the blacksmith equipment 10% bonus xp, along with the smithing master cape 2x boost to blast furnance, which I believe got missed during slash migration. https://bso-wiki.oldschool.gg/skills/smithing
Closes #4146
- [x] I have tested all my changes thoroughly.
which I believe got missed during slash migration.
should also verify this
Not quite sure how you mean but I have linked below various times the boosts can be seen in the code. Also don't see why the wiki would state it if it was never in the code, but can understand the caution on adding big boosts.
Dwarven gauntlets in the smelting code can be seen here - https://github.com/imgidedin/GidOSBot/blob/48c772124ecf4b387088622f1efde500b2c8213b/src/commands/Minion/smelt.ts Blacksmith outfit can be seen here - https://github.com/oldschoolgg/oldschoolbot/pull/2660 Smithing mastercape perk can be seen here - https://github.com/imgidedin/GidOSBot/blob/48c772124ecf4b387088622f1efde500b2c8213b/src/commands/Minion/blastfurnace.ts
Discord message around the time of moving stuff to blast furnace saying not to worry about blast furnace for bso - https://discordapp.com/channels/342983479501389826/648196527294251020/972119017575833650
So that's probably why it got missed, hope all this is sufficient but can try and find more if you need.
Reopened as I have further tested this and believe it is working as per rev: https://github.com/oldschoolgg/oldschoolbot/commit/b7c0e151fe73b3bcac13676833eb2c1a4142230d
Any further changes needed on this? Works how it should in testing, the same as it was pre mahoji changes.