react-native-select-picker icon indicating copy to clipboard operation
react-native-select-picker copied to clipboard

Published 20 hours ago • verified publisher icon olayinkaokewale

Remove empty selectable option

Open Jalson1982 opened this issue 4 years ago • 1 comments

Hello. I think it is quite confusing and possible error-prone if you allow user to select an empty value. Do not know what is purpose of it but if you still want to keep and you do not accept this PR then we can include some conditional and add a prop to remove it as again it could produce bugs if we allow selecting null as a value.

Jalson1982 avatar May 22 '20 18:05 Jalson1982

Sorry for the late replies...

I think it is better to create a prop to either remove or put it there. However, the reason for putting the empty selectable there is that on iOS by default, the first option is selected and if a user wanted that option it will not trigger the on change event in order to change the state of the selected item.

Let me know if your test shows otherwise.

olayinkaokewale avatar Jun 13 '20 12:06 olayinkaokewale