Google-Contacts icon indicating copy to clipboard operation
Google-Contacts copied to clipboard
verified publisher icon olalonde

fix params + adds missing id from getContact test

Open averissimo opened this issue 9 years ago • 4 comments

tests were not running correctly out of the box

extend was overwriting the params set by tests/usage

averissimo avatar Dec 15 '16 19:12 averissimo

Can you give an example of what this fixes? I'm not sure I understand. Also, remove the console.log line :)

olalonde avatar Dec 15 '16 20:12 olalonde

pulling the master branch and running npm run test has this output

all comments in respective lines (see the Files changed tab)

image

averissimo avatar Dec 15 '16 21:12 averissimo

Thanks. Would you like to maintain this module? I can add you as a contributor on github and npm. I don't really use this module anymore and don't have time to maintain it.

olalonde avatar Dec 15 '16 23:12 olalonde

after one pull request? :o

Sorry man, today was the first time I saw this and probably will be the last.

I was just checking if I could get contacts from hangouts chat_id, but unfortunately it can't

Seems like some folks at https://github.com/callinize/google-contacts/ have forked this module and are kinda active (createContact / updateContact / ...)

averissimo avatar Dec 15 '16 23:12 averissimo