Ólafur Páll Geirsson

Results 361 comments of Ólafur Páll Geirsson

I agree disabling classfile copying is not a priority. I was just adding an experience report that we have encountered difficult-to-reproduce problems with this feature when compiling large codebases. We...

I propose to close this ticket for now and keep it in mind for the future in case LSP adds richer metadata to `textDocument/publishDiagnostics`. As it stands, it's unclear how...

@ckipp01 it would be the responsibility of Bloop to register the appropriate file patterns for sbt/Mill.

> I think this is incomplete because the build client might want to know for each resource URI if it is a file or a directory. URIs ending with `/`...

The `roots` docstring should use a trailing slash for the example `["file://Users/name/dev/metals/src/main/scala/"]`

As I see it. From the client side, BSP abstracts over buildtool-specifics while LSP abstracts over language-specifics. On the server side, BSP abstracts over the IDE-specifics (whether language server or...

This is a good observation. How about adding `scaladocJars` and keeping `jars` unchanged? We should try to avoid breaking changes at all cost. It would have no effect in Scala...

Does IntelliJ use the Scaladoc jars? Metals doesn't use it. I'm curious if we need `scaladocJars` in the first place 🤔 Maybe we can add a separate BSP request to...

Thanks for bringing this up @keyboardDrummer! I agree with you that the motivation section still needs improvement and it would be good to refine it based on our discussions. >...

@mickaelistria in [Metals](https://scalameta.org/metals/) we trigger BSP compile requests on file save and update the status bar with compilation progress based on `build/taskStart` and `build/taskFinished` notifications ![2019-01-20 13 06 51](https://user-images.githubusercontent.com/1408093/51439005-8b673a80-1cb4-11e9-991d-428950728879.gif) We ...