Ólafur Páll Geirsson

Results 361 comments of Ólafur Páll Geirsson

I took the liberty to add TODO checkmarks for this ticket. I propose the index format is like this ```proto // Filename: META-INF/semanticdb/semanticdb-index message Indices { repeated Index indices =...

Thanks for reporting! I have encountered the same situation where the body of a Term.Function gets wrapped in Term.Block. Here is a minimized example ```scala @ val term = q"1"...

Sounds good. Another alternative is to remove the curly braces `{...}` around the lambda ```scala @ val term = q"1" term: Lit.Int = Lit.Int(1) @ q"foo({a => $term })" res3:...

Another good candidate for `SYNTHETIC` is any vals ```scala cat anyval.scala package a class Final(val x: Int) extends AnyVal ➜ target git:(master) ✗ scalac -Xprint:typer anyval.scala [[syntax trees at end...

Thank you for reporting! I think this is an interesting proposal and it's technically possible to implement this. The biggest open question IMO is how to display the values of...

This would be a really nice rewrite to have. However, it's a tricky one since - we currently don't emit semantic information for sugars, see https://github.com/scalameta/scalameta/issues/822 - we would also...

Example diff produced by this rule ```diff - import com.foo._ + import com.foo.{A, B} ``` assuming that only `com.foo.{A,B}` are the only symbols used from the wildcard import. This is...

We don't have the available data in semanticdb to resolve which symbols are imported from the wildcard.

I just reopened the issue with a more detailed motivation

A quick update: synthetics now have attached symbols, which means scalafix knows symbols that are used by implicits. We also visit both macro expandees and expanders, however we could miss...