Ólafur Páll Geirsson

Results 361 comments of Ólafur Páll Geirsson

Remaining bugs: https://gist.github.com/olafurpg/203ffbd16cd740acb996

Another false parse error from [this file](https://github.com/scala-native/scala-native/blob/master/nativelib/src/main/scala/scala/scalanative/runtime/Arrays.scala#L190) ``` scala """!(arr.cast[Ptr[Byte]] + sizeof[Ptr[_]]).cast[Ptr[Int]] = length """.parse[Stat].get :1: error: end of file expected but = found !(arr.cast[Ptr[Byte]] + sizeof[Ptr[_]]).cast[Ptr[Int]] = length ^...

The remaining remnants to close this issue URL | details | --- | --- | [sbt/A.scala#L2](https://github.com/sbt/sbt/blob/83f35b18d348d36611570642833976d0f6520a60/sbt/src/sbt-test/source-dependencies/qualified-access/A.scala#L2) | A.scala:3: error: { expected but \n foundpackage b ^ [akka/Logging.scala#L1071](https://github.com/akka/akka/blob/3698928fbdaa8fef8e2037fbc51887ab60addefb/akka-actor/src/main/scala/akka/event/Logging.scala#L1071) | Logging.scala:1072: error:...

Thank you for reporting! Can you elaborate on what APIs you are currently using and give an example of what is missing? The JavaScript facade is defined here https://github.com/scalameta/scalameta/blob/7c5c020cc0ff9b97d9029b315fb8659590236a2c/scalameta/parsers/js/src/main/scala/scala/meta/parsers/JSFacade.scala We...

@drom do you make transformations on the AST before calling `codegen`?

Thanks for the explanation. I estimate it requires some effort work to map from the JavaScript object into `scala.meta.Tree`, it would be a large pattern match that looks something like...

Another approach could be to expose public methods to contruct `scala.meta.Tree` instances, for example ```scala @JSExport() def applyInfix(lhs: Term, op: Term.Name, targs: List[Type.Arg], args: List[Term]): Term.ApplyInfix = ... ``` This...

To provide more details. The current `TreeSyntax` pretty-printer in Scalameta (`Tree.syntax` and `Tree.toString`) has several problems - It's unable to print comments - It has several roundtrip bugs where the...

@MasseGuillaume structure is unrelated to this PR, please open a separate ticket to discuss structure if you want. There is an unmerged WIP branch for paiges that seems to avoid...

I took a stab at moving scala-syntax to this repo in https://github.com/olafurpg/scalameta/compare/pretty?expand=1 - scala-syntax unit tests pass - slow property tests pass, but run ~3-5x slower than in scala-syntax repo...