ol-iver
Added additional commands
Added additional commands for AVR : cursor pad, settings and option menu, info as requested in https://github.com/ol-iver/denonavr/issues/289
I think you are always sending HTTP commands, even if the library is in telnet control mode. Or did I miss something here?
I think you are always sending HTTP commands, even if the library is in telnet control mode. Or did I miss something here?
Indeed I am not aware (yet) on how the library works. I added only HTTP commands. Is it the same command names for telnet ? Also one of the commands expects a reply, is it possible to get a response for telnet commands ? I will check after this anyway
Hi again, I added corresponding commands for telnet protocole according to this documentation https://www.heimkinoraum.de/upload/files/product/IP_Protocol_AVR-Xx100.pdf
I like the idea, thanks for your PR 🚀
This is a private project, so I don't have always enough time for it.
However, I'll check your PR this weekend 🙂
I just enabled the test. You could already start fixing the tests and the linting issues. In case you want to run them locally, please check the github workflows how you can run linting and unit tests.
Hi, I have added the missing commands (unit testings passed this time) and added public methods
Thanks 🙂
There is one last thing. You too many methods. Those decorated with @run_async_synchronously are deprecated and I removed them with https://github.com/ol-iver/denonavr/pull/291 for all other methods.
There are still a couple of linting issues 😅 Unless you contributed for the first time, Github does not start the tests automatically. Thus is would make sense if you run the code-format and the integration tests locally.
Hi,
I missed one of the formatting tasks. It should be (hopefully) ok this time
I have a question : are you sure that telnet is faster than HTTP commands ? It may be my setup but I find volume up/down more reactive with http commands
Thanks Damien
De : Oliver @.> Envoyé : jeudi 2 mai 2024 10:12 À : ol-iver/denonavr @.> Cc : albaintor @.>; Author @.> Objet : Re: [ol-iver/denonavr] Added additional commands (PR #290)
There are still a couple of linting issues 😅 Unless you contributed for the first time, Github does not start the tests automatically. Thus is would make sense if you run the code-formathttps://github.com/ol-iver/denonavr/blob/c70e8ce11cd1f9ef86053201588d41d1f63b6e14/.github/workflows/python-code-format.yml#L31-L42 and the integration testshttps://github.com/ol-iver/denonavr/blob/c70e8ce11cd1f9ef86053201588d41d1f63b6e14/.github/workflows/python-tests.yml#L34-L36 locally.
— Reply to this email directly, view it on GitHubhttps://github.com/ol-iver/denonavr/pull/290#issuecomment-2089864463, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4IHILAXQEKOZRI274DLJD3ZAHYOLAVCNFSM6AAAAABEZHF6YWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBZHA3DINBWGM. You are receiving this because you authored the thread.Message ID: @.@.>>
There was still an issue. I fixed the last one by myself. Please run the tests locally the next time 😉
The main advantage of telnet is that the properties of your receiver are updated immediately, even when you are pressing buttons on your remote control. When you use HTTP you have to poll for updates with async_update method.