Oskar Kwaśniewski
Oskar Kwaśniewski
Hey @cipolleschi, anything I can do to help you get this one merged?
@cipolleschi I've refactored the method to `set_build_setting` which accepts necessary arguments to set proper build settings. This method can remove `set_use_hermes_build_setting` and `set_node_modules_user_settings` methods (less code to maintain). I've also...
@cipolleschi Creating `RCTRootViewFactory` would be the ideal solution but I didn't want to introduce too many changes. However I'm not re-creating key components every time with this approach: `self.bridge`, `_reactHost`...
@cipolleschi I decided to jump straight into it and implement this class, I think it will make initialization of RN a lot easier also in brownfield apps. I tried to...
Hi, @cipolleschi would you be willing to take a look at this and let me know if you're interested in pursuing it? It may require some polish, but I'd like...
Thanks for your review @cipolleschi I think now it's much better the public interface is not changed except for the `runtimeSchedulerEnabled`, `bridge` and `bridgeAdapter` but those are properties that users...
@cipolleschi As discussed offline, I've refactored the implementation to drop the delegate pattern and now we pass a configuration object. I've also validated that this PR fixes a bug with...
Hey @cipolleschi, I've rebased the PR on top of the latest changes, is there anything I can do to help you get this merged?
You need to have a development team selected when building for real device. Your error clearly states what you need to do: ``` error: Signing for "MyProject" requires a development...
Hey @cortinico, you can assign me to [react/modules/deviceinfo/DeviceInfoModuleTest.java](https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/deviceinfo/DeviceInfoModuleTest.java)