MiniSim icon indicating copy to clipboard operation
MiniSim copied to clipboard

Published 20 hours ago • verified publisher icon okwasniewski

Feat: Connect device via WiFi

Open luisbytes opened this issue 1 year ago • 11 comments

It would be great if you could connect an Android v11+ device over WiFi by scanning the a QR Code just like Android Studio has it.

luisbytes avatar Nov 16 '23 03:11 luisbytes

@okwasniewski Shall I work on this

gokul1099 avatar Nov 21 '23 03:11 gokul1099

Hey, thanks for opening a new feature request. MiniSim focuses on emulators and does not connect / display real devices. That's something worth considering in the future but firstly we would need to support connecting the device through USB. Also, the QR Code scanning might be exclusive to Android Studio and we would need to reimplement it. So let's keep this issue open but it could be worked on only after implementing USB devices support.

@gokul1099 If you want to you can work on adding support for USB devices (or take something else).

okwasniewski avatar Nov 21 '23 08:11 okwasniewski

@okwasniewski Ok, I will work on some other issue. Can you explain that USB devices support feature? or is there any separate issue raised for that??

gokul1099 avatar Nov 21 '23 08:11 gokul1099

I will open a more detailed issue explaining what should be done to support this feature. For now let's focus on something else

okwasniewski avatar Nov 21 '23 09:11 okwasniewski

Hi I don't have all the technical knowledge, but I think it is not an exclusive functionality of Android Studio. It generates a QR code this has an information that occupies ADB.

Here is an implementation with node https://github.com/saleehk/adb-wifi/blob/master/src/index.js

luisbytes avatar Nov 23 '23 14:11 luisbytes

Hi I don't have all the technical knowledge, but I think it is not an exclusive functionality of Android Studio. It generates a QR code this has an information that occupies ADB.

Here is an implementation with node saleehk/adb-wifi@master/src/index.js

Yes, its a great plugin, I am using this for a long time, this works perfectly. I have also gone through implementation. It will be great if will add this to minisim.

gokul1099 avatar Nov 23 '23 14:11 gokul1099

Thanks for sending! I wasn't aware of that in that case it looks like this feature can be added to MiniSIm

okwasniewski avatar Nov 23 '23 14:11 okwasniewski

@okwasniewski Shall i work on this ??

gokul1099 avatar Dec 17 '23 16:12 gokul1099

@gokul1099 Sure, you can! However I think firstly it would be best to tackle #112 to finish that feature

okwasniewski avatar Dec 18 '23 08:12 okwasniewski

@gokul1099 Sure, you can! However I think firstly it would be best to tackle #112 to finish that feature

Ok let me try to fix that first

gokul1099 avatar Dec 18 '23 12:12 gokul1099

Now that #122 has landed this can be revisited 👍🏻

cc: @gokul1099

okwasniewski avatar Sep 07 '24 17:09 okwasniewski