primitives icon indicating copy to clipboard operation
primitives copied to clipboard

more storybook and test add

Open productdevbook opened this issue 1 year ago • 10 comments

The following areas need to be checked and tested again. Missing areas need to be repaired

Radix Storybook

We Example Storybook This is the best example and the old style of writing needs to be converted to this format.

Please post a comment if you would like to take part. and select components

3 step single pr may also be available.

Step 1 - Components Storybook

Example packages

  • [x] aspect-ratio @Cr0zy07
  • [x] avatar @Cr0zy07
  • [x] checkbox @Cr0zy07
  • [x] collapsible @Cr0zy07
  • [ ] dialog @Cr0zy07
  • [ ] hover-card
  • [x] label @Cr0zy07
  • [x] popover @productdevbook
  • [x] popper @productdevbook
  • [ ] progress @mohi0
  • [x] radio-group @Cr0zy07
  • [x] separator @Cr0zy07
  • [ ] slider
  • [ ] switch
  • [ ] tabs
  • [x] toast @Cr0zy07
  • [x] toggle @Cr0zy07
  • [x] toggle-group @Cr0zy07
  • [x] toolbar
  • [x] tooltip @YeSuX

Step 2 - Components Test

Example packages Vue Test Docs

component is create tests folder and move test or create test. You can integrate some of the stories and add them to your tests.

  • [x] aspect-ratio @Cr0zy07
  • [x] avatar @Cr0zy07
  • [x] checkbox @Cr0zy07
  • [ ] collapsible @Cr0zy07
  • [ ] dialog @Cr0zy07
  • [ ] hover-card
  • [ ] label @Cr0zy07
  • [x] popover @productdevbook
  • [x] popper @productdevbook
  • [ ] progress @mohi0
  • [x] radio-group @Cr0zy07
  • [x] separator @Cr0zy07
  • [ ] slider
  • [ ] switch
  • [ ] tabs
  • [x] toast @Cr0zy07
  • [x] toggle @Cr0zy07
  • [x] toggle-group @Cr0zy07
  • [x] toolbar
  • [x] tooltip @YeSuX

Step 3 Props and Types one file props.ts add

Example packages

  • [x] aspect-ratio @Cr0zy07
  • [x] avatar @Cr0zy07
  • [x] checkbox @Cr0zy07
  • [x] collapsible @Cr0zy07
  • [ ] dialog @Cr0zy07
  • [ ] hover-card
  • [x] label @Cr0zy07
  • [x] popover @productdevbook
  • [x] popper @productdevbook
  • [ ] progress @mohi0
  • [x] radio-group @Cr0zy07
  • [x] separator @Cr0zy07
  • [ ] slider
  • [ ] switch
  • [ ] tabs
  • [ ] toast @Cr0zy07
  • [x] toggle @Cr0zy07
  • [x] toggle-group @Cr0zy07
  • [x] toolbar
  • [x] tooltip @YeSuX

productdevbook avatar Sep 14 '23 03:09 productdevbook

I am willing to rewrite the first 5 components stories as a start!

However, I have a suggestion, what if we remove TailwindCSS and PostCSS from the devDeps and just use plain CSS?

Cr0zy07 avatar Sep 14 '23 07:09 Cr0zy07

However, I have a suggestion, what if we remove TailwindCSS and PostCSS from the devDeps and just use plain CSS?

I'll take a look at this, create a new pr and import it.

productdevbook avatar Sep 14 '23 08:09 productdevbook

However, I have a suggestion, what if we remove TailwindCSS and PostCSS from the devDeps and just use plain CSS?

I'll take a look at this, create a new pr and import it.

What do you mean by "import it", which part are you referring to?. Also, should I create a PR for each component story or all together?

Cr0zy07 avatar Sep 14 '23 11:09 Cr0zy07

import it this: https://github.com/oku-ui/primitives/pull/359

productdevbook avatar Sep 14 '23 12:09 productdevbook

Also, should I create a PR for each component story or all together?

@Cr0zy07 After sending the popper pr, you will see how it will work. Please Popper pr wait

productdevbook avatar Sep 14 '23 12:09 productdevbook

I can take the toolbar and the hover-card.

mustafa60x avatar Sep 15 '23 12:09 mustafa60x

@Cr0zy07 The 3 structures for each component should be collected in 1 pr, each component should be pr separately.

Why should we do all 3 together in one pr?

We can see bugs while writing the stories, so we need to fix the code. Also, since the code will change, I think it is best to finish the tests in the same place.

I sent popper pr and merged them, I updated the texts here, please check.

productdevbook avatar Sep 15 '23 13:09 productdevbook

@mturkoz93 added. Thank you :heart:

productdevbook avatar Sep 15 '23 13:09 productdevbook

I can contribute to progress bar

mohi0 avatar Nov 05 '23 14:11 mohi0

I can contribute to progress bar

Thank you. I added.

productdevbook avatar Nov 05 '23 14:11 productdevbook