okta-aws-cli-assume-role icon indicating copy to clipboard operation
okta-aws-cli-assume-role copied to clipboard

Double quotes in AWS options cause an error

Open martinrw opened this issue 2 years ago • 0 comments

Describe the bug Using certain options for aws commands (that require double quotes) with okta-aws causes the command to fail

To Reproduce Steps to reproduce the behavior: Trying to delete some files from s3 using the include and exclude options:

$ okta-aws sandbox s3 rm s3://martin-test-s3-commands --recursive --dryrun --exclude "*" --include "*.zip"
Unknown options:file1,file2,file3

In this example file1, file2 and file3 are just some files that happen to be in my current working directory

Expected behavior A clear and concise description of what you expected to happen. If you run the same command with vanilla aws cli it works:

$ aws s3 rm s3://martin-test-s3-commands --recursive --dryrun --exclude "*" --include "*.zip"
(dryrun) delete: s3://martin-test-s3-commands/dummy1.zip
(dryrun) delete: s3://martin-test-s3-commands/dummy2.zip
(dryrun) delete: s3://martin-test-s3-commands/dummy3.zip

We should be seeing the same result from the okta-aws command

Additional context Add any other context about the problem here.

There is a workaround but it's not ideal, you can escape the double quotes with a \

$ okta-aws sandbox s3 rm s3://martin-test-s3-commands --recursive --dryrun --exclude \"*\" --include \"*.zip\"
(dryrun) delete: s3://martin-test-s3-commands/dummy1.zip
(dryrun) delete: s3://martin-test-s3-commands/dummy2.zip
(dryrun) delete: s3://martin-test-s3-commands/dummy3.zip

I am using the latest version of Okta-aws-cli (3.0.0).

martinrw avatar Jan 12 '22 15:01 martinrw