terraform-provider-okta icon indicating copy to clipboard operation
terraform-provider-okta copied to clipboard

Handle multiple apps returned by SAML app data source, where one app exactly matches.

Open MatthewJohn opened this issue 1 year ago • 3 comments

In the case where there are two apps: "MyApp" and "MyApp 2". If the data source for saml apps queried with label "MyApp" and the API returns "MyApp 2" as the first app in the list, the data source will fail. This change now iterates through all of the apps returned and returning an exact match, if "label" has been specified.

MatthewJohn avatar Feb 08 '24 08:02 MatthewJohn

@MatthewJohn Thanks. We will review it

duytiennguyen-okta avatar Feb 09 '24 19:02 duytiennguyen-okta

Thanks @duytiennguyen-okta :)

MatthewJohn avatar Feb 21 '24 06:02 MatthewJohn

If you're ok with the suggestion, I will bring the PR in and update it @MatthewJohn

duytiennguyen-okta avatar Feb 23 '24 03:02 duytiennguyen-okta