terraform-provider-okta icon indicating copy to clipboard operation
terraform-provider-okta copied to clipboard

Consistency - align datasource_okta_group(s) `search` schema with datasource_okta_user(s)

Open exitcode0 opened this issue 1 year ago • 1 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

userSearchSchemaDescription is (imo) better than having raw access to the search string because it support the dynamic meta argument

I'd like to request that we align the datasource_okta_group(s) resources with this implementation

I'd like to ask about if a change like this would require a deprecation or other change management as it would change the schema and the expected value quite a bit Would something like this have to wait for a V5 release? Does the Okta provider team have any target dates for a V5 release? Is the team happy to cut new major versions as and when the requirement comes up?

New or Affected Resource(s)

  • dataSource_okta_group
  • dataSource_okta_groups

Potential Terraform Configuration

data "okta_groups" "this" {
  type                     = "OKTA_GROUP"
  compound_search_operator = "or"

  dynamic "search" {
    for_each = [
      "123",
      "456"
    ]
    content {
      name       = "id"
      comparison = "eq"
      value      = search.value
    }
  }
}

References

  • #0000

exitcode0 avatar Oct 25 '23 08:10 exitcode0

OKTA internal reference https://oktainc.atlassian.net/browse/OKTA-663322

duytiennguyen-okta avatar Oct 31 '23 15:10 duytiennguyen-okta