samples-js-react icon indicating copy to clipboard operation
samples-js-react copied to clipboard

OktaSignIn widget hangs silently if not provided a client id

Open berniedurfee opened this issue 5 years ago • 2 comments

Found this troubleshooting what turned out to be a typo. If the client id doesn't get passed to the widget, it hangs without any errors.

To reproduce, simply comment out this line:

https://github.com/okta/samples-js-react/blob/0753a9c894b1dcb4aa545e80ab1ddcf42d76ccd9/custom-login/src/Login.jsx#L29

I'm assuming spinning silently forever is not the expected behavior. I would expect an error to be thrown or some sort of message to show up. Not sure if this is an issue with the example or with the widget itself.

berniedurfee avatar Jun 09 '20 21:06 berniedurfee

@berniedurfee Thanks for the report. The widget is designed to work in multiple scenarios. The clientId parameter is required for OIDC flow, but not required for some other flows. We will consider how we can make this work better within the samples to avoid confusion. Thanks again!

aarongranick-okta avatar Jun 12 '20 19:06 aarongranick-okta

Internal ref: OKTA-306402

swiftone avatar Jun 19 '20 18:06 swiftone