okta-sdk-python icon indicating copy to clipboard operation
okta-sdk-python copied to clipboard

Update saml_application_settings_sign_on.py

Open mdrdannyr opened this issue 1 year ago • 4 comments

When reading from OKTA API, SAML Applications that have preconfigured attribution statements are stored within 'configuredAttributeStatements'.

This is currently not passed to the results var when using get_application

This fix updates the model so that the value is passed

mdrdannyr avatar Sep 05 '23 15:09 mdrdannyr

To provide more context and details:

This is what direct API call to OKTA using postman shows:

image

This is what the library returns from the get_application call:

image

As can be seen the configuredAttributeStatements are missing.

OKTA docs show the following regarding this key:

image

Uncertain if the code is correct and stands up to your own guidelines. Happy to work with someone to get this merged in

mdrdannyr avatar Sep 05 '23 15:09 mdrdannyr

closes #374

mdrdannyr avatar Oct 01 '23 06:10 mdrdannyr

Hi

@bryanapellanes-okta @bretterer

Hope you're both doing well.

Tagging you as i see you guys are quite active in the latest commits to master. Could either of you help me out here in getting this relatively small fix into a release?

mdrdannyr avatar Oct 16 '23 06:10 mdrdannyr

@mdrdannyr I apologize for the delayed response and thank you for your submission. To ensure integrity, please provide a unit test that fails prior to your proposed change and passes with your change in place.

We appreciate your engagement and thanks for using Okta!

bryanapellanes-okta avatar Jul 11 '24 15:07 bryanapellanes-okta