okta-sdk-golang icon indicating copy to clipboard operation
okta-sdk-golang copied to clipboard

feat: Avoid hitting rate limits by looking at `X-Rate-Limit-*` headers

Open erezrokah opened this issue 1 year ago • 49 comments

Describe the feature request?

Implement the best practices from https://developer.okta.com/docs/reference/rl-best-practices/#example-rate-limit-header-with-org-wide-rate-limit to avoid hitting rate limits, and also wait until the limit reset time instead of a retry/backoff mechanism.

New or Affected Resource(s)

All existing and new resources will be affected I think

Provide a documentation link

https://developer.okta.com/docs/reference/rl-best-practices/#example-rate-limit-header-with-org-wide-rate-limit

Additional Information?

I'm aware of the existing backoff and retry configuration, it seems better practice to follow the headers returned from the server

erezrokah avatar Feb 28 '24 21:02 erezrokah

agreed. we are hitting rate warnings on our instance and would love a way to throttle the speed of requests to stay within the api limitation.

tjpoe avatar Feb 28 '24 21:02 tjpoe

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Mar 14 '24 01:03 github-actions[bot]

Not stale

erezrokah avatar Mar 14 '24 10:03 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Mar 30 '24 01:03 github-actions[bot]

Not stale

erezrokah avatar Mar 30 '24 06:03 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Apr 14 '24 02:04 github-actions[bot]

Not stale

erezrokah avatar Apr 14 '24 06:04 erezrokah

Proposal at https://github.com/okta/okta-sdk-golang/pull/450, will wait for feedback before adding docs, tests and updating the template files that generate the code

erezrokah avatar Apr 17 '24 18:04 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar May 02 '24 01:05 github-actions[bot]

Not stale

erezrokah avatar May 02 '24 05:05 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar May 18 '24 01:05 github-actions[bot]

Not stale

erezrokah avatar May 18 '24 05:05 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Jun 02 '24 01:06 github-actions[bot]

Not stale

erezrokah avatar Jun 02 '24 06:06 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Jun 17 '24 01:06 github-actions[bot]

Not stale

erezrokah avatar Jun 17 '24 07:06 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Jul 02 '24 01:07 github-actions[bot]

Not stale

erezrokah avatar Jul 02 '24 05:07 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Jul 17 '24 01:07 github-actions[bot]

Not stale

erezrokah avatar Jul 17 '24 05:07 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Aug 01 '24 01:08 github-actions[bot]

Not stale, will try to respond to https://github.com/okta/okta-sdk-golang/pull/450 soon

erezrokah avatar Aug 01 '24 09:08 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Aug 16 '24 01:08 github-actions[bot]

Not stale

erezrokah avatar Aug 16 '24 10:08 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Aug 31 '24 01:08 github-actions[bot]

Not stale

erezrokah avatar Sep 03 '24 20:09 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Sep 18 '24 01:09 github-actions[bot]

Thank you for the bump dear stale bot, not stale

erezrokah avatar Sep 18 '24 09:09 erezrokah

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

github-actions[bot] avatar Oct 03 '24 02:10 github-actions[bot]

Not stale

erezrokah avatar Oct 03 '24 10:10 erezrokah