okta
feat(arch): add support new arch
Hi @ngocle2497, thanks for contributing this PR! It will take some time for me to review this PR given the size. But I have a few comments/questions:
- I see that you removed e2e test app, and added example app. Did the e2e app have issues with these changes? If not, I would prefer e2e app to not be removed. If there were issues here, I'd like to understand what they are.
- Similarly, files under script folder shouldn't be removed either. There are some files there used in our internal build system.
- test/index.test.js was removed. This is a necessary file for our JS unit tests, and this PR should ensure those tests are still passing. I am okay with moving this file to a different directory, as long as the tests are still there and we can run them.
I will review this in more details soon. But after a quick glance at your PR, everything else seems to be looking good. Thanks again for your contribution!
Hi @ngocle2497, thanks for contributing this PR! It will take some time for me to review this PR given the size. But I have a few comments/questions:
- I see that you removed e2e test app, and added example app. Did the e2e app have issues with these changes? If not, I would prefer e2e app to not be removed. If there were issues here, I'd like to understand what they are.
- Similarly, files under script folder shouldn't be removed either. There are some files there used in our internal build system.
- test/index.test.js was removed. This is a necessary file for our JS unit tests, and this PR should ensure those tests are still passing. I am okay with moving this file to a different directory, as long as the tests are still there and we can run them.
I will review this in more details soon. But after a quick glance at your PR, everything else seems to be looking good. Thanks again for your contribution!
- During the migration, I recreated the library instead of migrating (it made the migration easier), so example is the default directory. Furthermore, e2e is a javascript template. Typescript has been the default template for quite a while so I thought it would be a good idea to upgrade to avoid confusion or difficulties when running the example project.
- brought it back
- brought it back
Hi @ngocle2497, I've merged your changes into a local feature branch. I'm going to do a couple sanity checks to make sure everything is working properly, and will then release the changes into master. Thanks again for the changes!
@rajdeepnanua-okta as far as I can tell this change hasnt been included in a new release yet, do you have any insight into when that will be published?
