okta-developer-docs icon indicating copy to clipboard operation
okta-developer-docs copied to clipboard

[OKTA-727700] Fixed odyssey icons in dark theme

Open ishan-krishna-okta opened this issue 1 year ago • 2 comments

Description:

  • What's changed? Fixes odyssey icons in dark theme
  • Is this PR related to a Monolith release?

Resolves:

ishan-krishna-okta avatar May 10 '24 06:05 ishan-krishna-okta

Acrolinx score

A minimum Acrolinx Score of 80 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, for example: Correctness. Your content will be clearer and more consistent.

Article Total score
Required:70
Word and phrases
(Brand, terms)
Preferred: 80
Correctness
(Spelling, grammar)
Preferred: 80
Clarity
(Readability)
Preferred: 80
Inclusive language
(+ accesibility)
Preferred: 80
:white_check_mark: packages/@okta/vuepress-site/docs/guides/submit-oin-app/main/index.md 84 86 90 69 100

acrolinxdevdocs-okta avatar May 10 '24 06:05 acrolinxdevdocs-okta

Semgrep found 1 react-jwt-decoded-property finding:

  • packages/@okta/vuepress-theme-prose/util/coveo/endpoint.js

Property decoded from JWT token without verifying and cannot be trustworthy.

Ignore this finding from react-jwt-decoded-property.

semgrep-app[bot] avatar May 10 '24 06:05 semgrep-app[bot]

Acrolinx score

A minimum Acrolinx Score of 80 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, for example: Correctness. Your content will be clearer and more consistent.

Article Total score
Required:70
Word and phrases
(Brand, terms)
Preferred: 80
Correctness
(Spelling, grammar)
Preferred: 80
Clarity
(Readability)
Preferred: 80
Inclusive language
(+ accesibility)
Preferred: 80
:white_check_mark: packages/@okta/vuepress-site/docs/guides/submit-oin-app/main/index.md 84 86 90 69 100

acrolinxdevdocs-okta avatar May 13 '24 07:05 acrolinxdevdocs-okta

Great job and good approach! One request is to remove -odys part from file names, so that files will match the source https://github.com/okta/odyssey/tree/main/packages/odyssey-icons/src/figma.generated

Done.

ishan-krishna-okta avatar May 13 '24 07:05 ishan-krishna-okta