okta-angular icon indicating copy to clipboard operation
okta-angular copied to clipboard

Fix: handle routes without path segments

Open PatrickSchnoop opened this issue 2 years ago • 0 comments

Protect lazy loaded routes without path segments with canLoad-Guard.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Adding Tests
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation changes
  • [ ] Other... Please describe:

What is the current behavior?

If you want to protect a route without any path segments with a canLoad-Guard, an exception is thrown.

const routes = [{
 path: '',
 canLoad: [ OktaAuthGuard ],
 ...
}]

Issue Number: N/A

What is the new behavior?

Routes without path segments can be protected with a canLoad-Guard.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Reviewers

PatrickSchnoop avatar Apr 26 '22 20:04 PatrickSchnoop