pytorch-timeseries icon indicating copy to clipboard operation
pytorch-timeseries copied to clipboard

InceptionTime blocks incorrectly implemented

Open RossDeVito opened this issue 3 years ago • 2 comments

The general flow of data for an inception block is:

input data -> bottleneck -> [filters of different sizes] -> output

In your implementation, the filters of different sizes are applied sequentially like this:

input data -> bottleneck -> filter_size_a -> filter_size_b -> filter_size_c  -> output

In the actual implementation the flow is something like the following.

input data -> bottleneck -> { -> filter_size_a ->         } -> concat-> output
                                -> filter_size_b ->
                                -> filter_size_c ->
                                -> max_pool_filter ->

RossDeVito avatar Jun 28 '21 20:06 RossDeVito

I notice that too @RossDeVito and absolutely agree.

dvirnimrod avatar Jul 22 '21 12:07 dvirnimrod

Same here.

jumdc avatar Apr 30 '23 08:04 jumdc