ok icon indicating copy to clipboard operation
ok copied to clipboard

Published 20 hours ago • verified publisher icon okpy

Slips Calculator Job

Open matulka opened this issue 4 years ago • 9 comments

This pull request is supposed to solve the problem addressed in #1375

This is an updated version of #1068 which takes into account most of the comments for that PR. The main changed made is that in the initial PR slips were calculated for each of user's submissions and in this PR they are calculated only for the final submission.

Slips can be calculated both for the whole course (with an option to change which exact assignments should be included) and for individual assignments.

Calculating for the whole course

Calculating slips for an assignment

Output of the job is an .csv table which contains and SID, email and the amoung of slip days (or hours, minutes) used by a student. If a student has not used slip days, they will not be included in the table.

Calculating slips log

Output csv for a specific assignment

matulka avatar Mar 04 '20 21:03 matulka

I think this will be great, but is it possible to have per-assignment slip time in the course CSV? So the header is ..., Total Slip {}, Assignment 1, Assignment 2, ...

cycomachead avatar Mar 06 '20 05:03 cycomachead

@cycomachead Yeah sure, I will make it this week

matulka avatar Mar 07 '20 04:03 matulka

@cycomachead Hey! Sorry for the delay. Check the course slips once again, I think I have made it the way you ask. Also, I have noticed a problem that sometimes it displays an SID and sometimes it doesn't. I think this is connected to the fact that in the current architecture of the database SID and User are connected using Enrollment, so it supports the possibility of a student being enrolled in different courses with different SIDs. When calculating course slips, I take the SID connected to the current course, while when calculating assignment slips, I take the SID from some random enrollment associated with this student (because it is faster this way than manually looking through all enrollments and picking the right one, O(1) vs. O(n)). Should I fix this and change to picking the SID from a specific enrollment? This shouldn't be a problem if in the actual database all students have the same SIDs for each course.

matulka avatar Mar 24 '20 12:03 matulka

@matulka Yes, this looks awesome now!! Thank you so much!! 🎉 🎊

cycomachead avatar Mar 26 '20 02:03 cycomachead

@cycomachead Great! You are welcome :)

matulka avatar Mar 26 '20 15:03 matulka

Any chance this could be merged soon or there is a way to run this, just to double check?

cycomachead avatar Dec 09 '20 00:12 cycomachead

Can I get a bump on this? :) @matulka @rahularya50 Thanks!

cycomachead avatar Feb 09 '21 01:02 cycomachead

Hey @cycomachead ! Sorry so much for a late response. The thing is that I have not been working on okpy since the May of last year, so I have no idea about the possibility of merging this :(

matulka avatar Feb 22 '21 14:02 matulka

No worries, thank you! :)

cycomachead avatar Feb 23 '21 08:02 cycomachead