ok-client icon indicating copy to clipboard operation
ok-client copied to clipboard

Files should be submitted even if importing fails

Open albertkx opened this issue 5 years ago • 2 comments

Some students have run into issues where they have top-level syntax errors, i.e. indentation issues, that prevent their assignment file from being imported. This also prevents ok client from submitting the file.

image

We should have ok client submit the assignment file to okpy even if top-level syntax errors cause local testing to error, so we have a submission which we can regrade.

albertkx avatar Mar 05 '19 03:03 albertkx

Will look into this

ja5087 avatar Mar 22 '19 22:03 ja5087

The issue is due to how the client imports all dependencies listed in the config.ok file to build the Assignments object, then errors since the test file cannot be loaded as a module. I will look into writing it so the code only loads the tests as the doctests protocol is run so other protocols (namely, backup) can still run.

ja5087 avatar Apr 01 '19 21:04 ja5087