Omkar Kolekar

Results 22 comments of Omkar Kolekar

> Also I misspoke earlier about Windows difficulties, I was correlating tests failing with issues on Windows platform but the checks here on GitHub run on linux (Ubuntu) only currently....

> This branch is based on a somewhat old version of `eis_toolkit`. Can you do a merge and push it. Run the following commands in the repository with your edits...

> The code in terms of functionality seems to be working well in tests and in the notebook. My comments mostly relate to style and trying to minimize code duplication,...

> I suppose this is ready for review again? I will take a look in a week (or two). Yes, it is ready for review again. Thank you for the...

> This PR needs to be merged this week if we want to include it in the released planned for Friday this week. If Nikolas is busy, I might jump...

> Hi @okolekar . I only now realized you have been optimizing `distance_to_anomaly` here, not`distance_computation`. The issue and PR name refer to `distance_computation` which is the vector processing tool that...

@nmaarnio I have made the requested changes. Now I will shift my focus to optimize the Distance_computation in the vector processing tool.

> Hey, a quick review: The tool should not take in an already computed distance array, but instead perform the distance computation within this proximity tool. It is already possible...

> Also see issue #430 which was made for this feature So should I make a commit there or should it be here (I am referring to the pull request...

The tool now takes in a GeoDataFrame, raster profile and maximum distance as inputs and performs the inversion by calling distance computation function inside the tool itself. Logarithmic scaling is...