toml-bombadil icon indicating copy to clipboard operation
toml-bombadil copied to clipboard

Ignore more vcs and temp file dirs and reload bombadil config on changes

Open svenstaro opened this issue 2 years ago • 6 comments

Before it would pick up stuff even in the internal .git dirs and such. This should get rid of that.

This also adds reloading of the bombadil config itself if changes are detected.

svenstaro avatar May 26 '22 01:05 svenstaro

I think the failures are flaky tests and not my PRs fault.

svenstaro avatar May 26 '22 01:05 svenstaro

@oknozor ping

svenstaro avatar Jun 20 '22 18:06 svenstaro

Hey @svenstaro I will not be able to look at this before next week. I'll take a look as soon as I can

oknozor avatar Jun 20 '22 19:06 oknozor

:heavy_check_mark: 4da93e6...ec413da - Conventional commits check succeeded.

cocogitto-bot[bot] avatar Jun 22 '22 13:06 cocogitto-bot[bot]

Codecov Report

Merging #132 (ec413da) into main (5e3c148) will decrease coverage by 0.62%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   69.66%   69.04%   -0.63%     
==========================================
  Files           9        9              
  Lines        1780     1796      +16     
==========================================
  Hits         1240     1240              
- Misses        540      556      +16     
Impacted Files Coverage Δ
src/lib.rs 55.95% <0.00%> (-1.60%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jun 22 '22 13:06 codecov[bot]

@oknozor How do you feel about this? I can rebase but only if there's upstream interest.

svenstaro avatar Aug 23 '22 22:08 svenstaro

Hey @svenstaro It's been a while.

This will not be needed when #156 is merged. Once it's merged bombadil link bombadil watch will relink only modified dotfiles, leaving the unmodified untouched.

Also it now open the dotfiles and modify them instead of recreating them on each link command. This should solve some issue with app that have config hot reload (for instance alacritty)

oknozor avatar Nov 29 '22 13:11 oknozor