DOFavoriteButton icon indicating copy to clipboard operation
DOFavoriteButton copied to clipboard

Published 20 hours ago • verified publisher icon okmr-d

Swift3 update

Open indrajitsinh opened this issue 8 years ago • 6 comments

Swift3

indrajitsinh avatar Oct 01 '16 06:10 indrajitsinh

@indrajitsinh I just noticed that there are already 4 PRs for Swift 3 support. Since the developer is inactive and probably won't accept the PRs, should we just remove this item from the list at https://github.com/vsouza/awesome-ios and add a fork of ours? I'm just asking (also I'm assuming that you found that repository there) because it doesn't quite fit into the criteria at https://github.com/vsouza/awesome-ios/blob/master/.github/CONTRIBUTING.md. Also I find it a real shame if this repository couldn't be used anymore without converting and fixing bugs. Maybe you could drop a opinion and I'm tagging you because you have the most recent PR. Thanks!

ph1ps avatar Oct 03 '16 17:10 ph1ps

@indrajitsinh Please don't use the commits from my branch to open a new PR. There is another PR in progress already https://github.com/okmr-d/DOFavoriteButton/pull/30 that you should use (which is why I closed my PR in the first place).

seemakamath avatar Oct 06 '16 17:10 seemakamath

@seemakamath #30 is actually not a working build thats why I submitted #35 . Did you try building and running it?

ph1ps avatar Oct 06 '16 21:10 ph1ps

@ph1ps Can you provide more details in terms of what's not working? Have you checked out this comment? https://github.com/okmr-d/DOFavoriteButton/pull/30#issuecomment-247398348

seemakamath avatar Oct 06 '16 22:10 seemakamath

@seemakamath https://github.com/okmr-d/DOFavoriteButton/pull/30 does not work. Adding self.layoutIfNeeded() as mentioned in one of the comments will mess upp the constraints

kiwo12345 avatar Oct 07 '16 00:10 kiwo12345

@kiwo12345 Regardless, let's help get #30 merged by giving feedback there.

seemakamath avatar Oct 07 '16 17:10 seemakamath