Adding modules does not work in Safari

[valtism]

Just found out about this project. Looks awesome, especially because Bundlephobia has been pretty flaky as of late.

In Safari, when selecting a package from the search select box, clicking add does nothing. Looks like the search results box is closing before the selection is made. No console output unfortunately.

https://user-images.githubusercontent.com/1286001/170160117-e1b4c98c-454d-4dea-9030-02b735006d88.mov

[okikio]

I'm having trouble recreating this issue (I don't have a mac so that might be why 😅). Right now I'm using Gnomes Epiphany browser on WSL to test WebKit, but as I don't have a Mac I can't test on Safari directly. Could you please clear the cache and try clicking the add button again.

For the search results I am using CSS :focused-within to keep the results shown, so the problem is most likely related to :focused-within, not working properly for some reason. 🤔

[valtism]

Yeah, cleared cache and is still persisting. I would say that Safari is handling focus states differently so focus is either being dropped or is not considered within the input so :focused-within turn off before the click goes through.

I think it would be better to handle the open state as actual state in a useSignal because :focused-within does feel a little hacky.

I can have a look at fixing this myself later if you are struggling with replication, but I may take a while to get around to it.

[okikio]

I'll try to get on it as soon as possible, I am currently working on porting the entire project over to Astro

[valtism]

Yeah no rush. Still works with manually typing in the package name. Will be keeping an eye on this project because it looks super nice 👍

[MauriceArikoglu]

Can confirm it NOT working on any iPhone browser either @valtism @okikio

[okikio]

@MauriceArikoglu Thanks for notifiying me, I'm working on it

[MauriceArikoglu]

@okikio thanks for the app. It's honestly great. Just a bummer I can't use it on iPhone while on the go.. 👍 if you need help let me know, I'm down for having a look or call etc.

[okikio]

Yeah, I'm having trouble debugging this. Please try the beta version https://bundlejs.netlify.app does this have the same error from your side

[okikio]

@MauriceArikoglu After a bit of debugging it seems this issue only occurs on iOS 16 but on iOS 16.1 everything seems fine

[okikio]

I think this is resolved

[valtism]

Confirming this works on Safari on the beta version, but it does not work on the current prod version. Tried with private browsing too, and unregistering service workers.

[okikio]

Interesting...ok I'll try to backport a fix

[valtism]

Also, should mention this is Safari 16.3 on macOS.

[valtism]

Although testing on iOS also doesn't work. I think it works on beta because the popover doesn't close