David Heidelberg
David Heidelberg
I quickly re-iterated and applied suggestions and implemented proposed changes. I wish I could invest more time, but until the end of the month, I'm deeply busy. Hope it looks...
Re-tested, latest Minetest master + this MR; Irrlicht master + https://github.com/minetest/irrlicht/pull/278 . IMHO Works well.
@rubenwardy pretty please, one review for me (I think I'll have to keep rebasing it all the times otherwise)
@rubenwardy do I understand right the MR works correctly when based on https://github.com/minetest/minetest/commit/2ef080a51b5982e4e2ce17953f2a9cc62edf13fa but digging not working when based on `master`?
@rubenwardy found it, it was 404a063fdfbbddcba32d22dd1c34dd73922bc12a adding another check. We need to merge it rather sooner than later, it keeps breaking every few commits.
For **next followup PR**, I have prepared basic auto-detection MR for Linux, which will set sane defaults regarding to touchscreen if knows the device form factor (tablet/handheld/phone).
Tested on: - Android (Pixel 7 PRO, works as expected) - Linux - TS enabled (phone, OnePlus 6) - TS disabled (laptop) - Windows (laptop w/ touchscreen) - TS disabled,...
Follow up: https://github.com/minetest/minetest/pull/14400
as a bonus, GCC lto brings some extra [ODR](https://en.cppreference.com/w/cpp/language/definition) rule warnings: ``` /home/okias/projects/minetest/lib/irrlichtmt/include/IEventReceiver.h:585:7: warning: virtual table of type ‘struct IEventReceiver’ violates one definition rule [-Wodr] 585 | class IEventReceiver |...