opendatasurvey icon indicating copy to clipboard operation
opendatasurvey copied to clipboard

Unable to update entry due to incorrect validation

Open Stephen-Gates opened this issue 7 years ago • 4 comments

I'm trying to update http://australia.census.okfn.org/submit/?place=nsw&dataset=timetables but get screenshot 2016-08-02 20 49 12

I believe the changes I'm making to the values should not be errors.

Stephen-Gates avatar Aug 02 '16 11:08 Stephen-Gates

@brew pls take a look

pwalsh avatar Aug 02 '16 11:08 pwalsh

It's not very clear in the current entry form, but some questions, if false, require other questions to also be answered false. e.g. If 'Publicly available' is answered 'No', then 'Free', 'Online', 'Open Licence' and 'Bulk' should also be 'No'. [1]

@Stephen-Gates Do you think this is what's happening with your submission?

[1] This is hard-coded in a validator: https://github.com/okfn/opendatacensus/blob/28fe2e5b949a23043e3ce5849abd96fdd27f130e/census/controllers/utils.js#L30

brew avatar Aug 02 '16 15:08 brew

@brew I think that's what's happening but I also think the validation is wrong. The dataset is not publicly available, you have to register. Once you've registered, it is free, online, available in bulk and openly licenced.

Stephen-Gates avatar Aug 02 '16 19:08 Stephen-Gates

@Stephen-Gates agreed, this is something that we are changing this year. There will be a subquestion, if no, where users can specify the restriction to access (for example, registration) and then can continue on with the survey.

KateRogers avatar Aug 03 '16 14:08 KateRogers