opendatasurvey icon indicating copy to clipboard operation
opendatasurvey copied to clipboard

Change log not showing all events

Open Stephen-Gates opened this issue 9 years ago • 5 comments

I accepted a submission for http://global.census.okfn.org/entry/ae/weather but use incorrect Markdown formatting.

I added another submission, corrected the Markdown, and Published. These events are not shown in http://global.census.okfn.org/changes/

The detail of the original submitter is not displayed on

  • http://global.census.okfn.org/entry/ae/weather or
  • http://global.census.okfn.org/place/ae

Stephen-Gates avatar Oct 05 '15 01:10 Stephen-Gates

Hi @Stephen-Gates

You rejected the original submitter's submission, so of course her/his details would not be displayed on the new submission you made - the details would be your details, or anonymous (depending on how you submitted).

I'll checking the issue with how this is displayed in 'changes' now.

Edit: Or, maybe you did not reject the original submission?

pwalsh avatar Oct 05 '15 05:10 pwalsh

G'day @pwalsh (I hope you caught some AFL or NRL Grand Final action over the weekend)

I did not reject the submission but I did :

  • Publish/Accept
  • Submit
  • Publish/Accept

I was expecting to see each transaction in Changes.

Re: Submitter details. I thought it might accumulate past submitters to give credit for past contributions within that year. (Probably more applicable to Local census).

Stephen-Gates avatar Oct 05 '15 05:10 Stephen-Gates

@Stephen-Gates ok checking. No, I didn't catch AFL or NFL Grand Final action :).

pwalsh avatar Oct 05 '15 05:10 pwalsh

@Stephen-Gates ok, I've investigated. I'm not sure if we should consider these issues "bugs" or "features". I'll let @morchickit or @nealbastek prioritise the action (if any). The scenario is:

  1. All data exposed to the user interface has been processed, and we have lists of data like this, for each year:
    • entries: all the current entries
    • submissions: all the pending submissions
    • rejected: all the rejected submissions
  2. So, entries in a given year, that used to be the "current entry", do not fit into any of these lists - they are in the database, but not exposed to the user interface
  3. That means that, within a given year, we only see:
    • The reviewer and submitter for the current entry
  4. For views that should multiple year data, we see the reviewers and submitters for the current entry for each year
  5. As with above, on the changes page, changes related to entries that are no longer "current", but are also not "pending submissions", and are not "rejected", do not show on the changes list.

That explains what you see.

pwalsh avatar Oct 05 '15 06:10 pwalsh

ok thanks for looking in to it @pwalsh

Stephen-Gates avatar Oct 05 '15 06:10 Stephen-Gates