opendataeditor icon indicating copy to clipboard operation
opendataeditor copied to clipboard

Improve datagrid to help the user read errors - Research

Open romicolman opened this issue 1 year ago • 4 comments

Problem description

Right now, when the ODE previews the table, the app only indicates row numbers.

Captura de pantalla 2024-06-17 a la(s) 10 51 46 a  m

However, the error report will include the cell location to help the user identify errors. Therefore, we need to incorporate a table header, like the one Datawrapper, for example, has:

Captura de pantalla 2024-06-17 a la(s) 10 57 42 a  m

Is this possible?

romicolman avatar Jun 17 '24 08:06 romicolman

I really like Datawrapper's approach to solving this problem. I'd use it as a starting point

Faithkenny avatar Jun 17 '24 14:06 Faithkenny

Hello @romicolman , I have added the column headers and it seems to be working fine, so I think the conclusion is that it can be done 💯 ✨ and we can keep this one for the complete version. You can see in the PR #436 . This PR does not include updating the error reports, though. This PR is only adding the headers. Should we create another issue for updating the error reports to identify the cells by column letter and number, since this is only the research part?

guergana avatar Jun 22 '24 12:06 guergana

Hey @romicolman I was just thinking of what happens when there are more than 26 columns ... My example only covers the letters of the alphabet.

Will the column after Z be 'A1' or 'AA' ? Do we have maximum amount of columns that the app supports?

guergana avatar Jun 23 '24 07:06 guergana

Heyyy! Thanks for all the info.

Let's keep the same logic that we see in Google Sheets, Excel: A-Z and then 'AA', 'AB', 'AC', 'AD'. Since this is a research ticket, I'll create a new one and mention this issue.

Errors report: yes...we need to update that. We are working on it.

romicolman avatar Jun 24 '24 11:06 romicolman