cqrlog icon indicating copy to clipboard operation
cqrlog copied to clipboard

Online log upload

Open dl7oap opened this issue 5 years ago • 7 comments

the online log upload function stops, when

  • it tries to delete a qso, which is not in the in the online log (clublog gives http error 500)
  • the online log service is not online/shut down

the online log function should not stop, but

  • continue with the next qso upload/change/delete
  • continue with the other online log services (some user uploads parallel to hamqth/hrdlog/clublog)
  • log errors which can not been upload/change/delete in a file (~/cqrlog_upload_error.log), so user can take care for the qsos which have problems

this issue only occure on clublog and hrdlog. hamqth works well and is not affected.

dl7oap avatar May 10 '19 15:05 dl7oap

more hints and details to this error

  • https://www.cqrlog.com/node/2195
  • https://www.cqrlog.com/node/2299
  • https://www.cqrlog.com/node/2346 (clublog gives http error 500 when qso not found)

dl7oap avatar Jun 12 '19 18:06 dl7oap

@dl7oap Could you please test this?

https://github.com/phl0/cqrlog/commit/60af4fd3e384070698ac058289a6e5111d25f121

Not sure if that breaks something else but at least it continues in case in cannot upload/delete a QSO.

phl0 avatar May 27 '20 19:05 phl0

I made a new approach solving this issue:

https://github.com/ok2cqr/cqrlog/compare/master...phl0:moreDetailedErrorHandlingForOnlineLogs

Basically FatalError was changed to an integer variable being 0 for no errors, 1 for fatal error (upload completely stops) or 2 in case that the error is not fatal and upload should simply continue with the next QSO to upload, @dl7oap Would you be able to verify my changes?

phl0 avatar Jul 07 '20 12:07 phl0

Hi, i did a CodeReview and the Code looks fine for me. I only use hamqth, so i can not test it in real life.

Bye dl7oap

dl7oap avatar Jul 08 '20 05:07 dl7oap

There is at least one point where it should continue with HamQTH upload:

Bildschirmfoto vom 2020-07-09 10-45-30

But I think we cannot provoke this situation... :)

phl0 avatar Jul 09 '20 08:07 phl0

This bug is still present on CQRLOG 2.6.0 for Clublog and HRDLog as I highlighted on the CQRLOG Forum.

73's de PY1ZRJ

mcalistri avatar Aug 15 '22 20:08 mcalistri

I made a new approach solving this issue: https://github.com/ok2cqr/cqrlog/compare/master...phl0:moreDetailedErrorHandlingForOnlineLogs

The patch works fine for HamQTH and Clublog. Unfortunately, HRDLog is not working (at least to me).

ra1nb0w avatar Jul 21 '23 12:07 ra1nb0w