Jonas Mårtensson

There is some more documentation here: https://github.com/Telecominfraproject/oopt-gnpy/blob/master/examples/edfa_model/amplifier_models_description.rst The sentence "It uses a 3rd order polynomial where NF = f(gain)" in the main README is maybe a bit misleading and should...

So to clarify, in your equation above `x` does not represent the `gain_target` directly but rather `gain_target-gain_flatmax`. (The documentation I linked to is maybe even more confusing because of the...

It seems Python bindings (libyang-python) support for the newer version 2 is "planned before the end of the year": https://github.com/sysrepo/sysrepo-python/issues/12#issuecomment-905272635 In this case, wrapping the C++ bindings seems like unnecessary...

Would depending on libyang mean that GNPy cannot run natively on Windows anymore?

> What `libyang` needs is only `libpcre2`, and a C compiler and CMake, so it will be "just" a matter of invoking `cmake` (and somehow building PCRE2). Yes but from...

Maybe another track that could be explored is to try and improve the performance of yangson. By a couple of simple optimizations I was able to shorten validation time on...

> A small update: my patches which port `libyang` to Windows have been merged upstream. That's a _not so_ small achievement - good work!

Digging a bit deeper... It seems the python launcher is now the "recommended" way to invoke python on Windows. Unfortunately this does not work with a version-specific shebang (i.e. python3...

With the reservation that I didn't implement the `variable_gain` "operator model" (so I might have things wrong) here are some comments based on by understanding: This model tries to simulate...

Let me try to illustrate where potential confusion may arise. With a standard Fiber element we have this: Fiber -> connectors (patch panel) -> EDFA The Fiber con_out, as specified...