mkdocs-git-committers-plugin-2 icon indicating copy to clipboard operation
mkdocs-git-committers-plugin-2 copied to clipboard

Improve matching for gitlab users

Open 73VW opened this issue 4 months ago • 1 comments

Hello there 👋🏻,

Actually, the comparison between the user having commited and gitlab users is done this way:

if user['name'] == commit['author_name']:

which I find too strict.

Sadly, Gitlag does not include the username in the commits API. That would have been the best way to go.

However, I think that a comparison ignoring accents and case could really improve the matching. Chances that two commiters with the names Bob example and Bob Example are two different people are IMHO very slim.

If the Gitlab user is set to Bob Exämple, no commits would match.

What do you think?

I can open a PR to improve this.

73VW avatar Jul 23 '25 15:07 73VW

Hi @73VW - thanks for the suggestion. I don't have data to prove or disprove that name matching is an issue, but being a bit more loose (under a setting?) might indeed be interesting.

Feel free to submit a PR.

ojacques avatar Jul 25 '25 05:07 ojacques