mkdocs-git-committers-plugin-2 icon indicating copy to clipboard operation
mkdocs-git-committers-plugin-2 copied to clipboard

GitHub Enterprise disaplays no avatars

Open mihaigalos opened this issue 1 year ago • 2 comments

Using GH Enterprise, my user's avatar's URL is correctly fetched from the repo's commit, containing something like:

https://avatars.company.com/u/8554\?\&size\=72

This is ok, since an auth_header is used. But when dynamically resolving the src for the image, no auth is used and the avatar is not displayed, since the URL is not authorized:

Screenshot 2024-06-15 at 16 14 04

I think this is a missing feature for auth, or the plugin may need to potentially download the avatar as an asset in the .cache folder and serve it from there.

I'm using this config:

plugins:
  - git-committers:
      enterprise_hostname: company.com
      repository: orga/repo
      api_version: v3
      branch: main

mihaigalos avatar Jun 15 '24 14:06 mihaigalos

I know this is an authentication problem, because if I:

curl -sSLk https://avatars.company.com/8554\?\&size\=72

I get a "please login" page.

mihaigalos avatar Jun 15 '24 14:06 mihaigalos

Ok. So apparently, the avatars.* URL is not accessible via token since it contains an OAuth flow.

mihaigalos avatar Sep 26 '24 15:09 mihaigalos

Ok. So apparently, the avatars.* URL is not accessible via token since it contains an OAuth flow.

Agreeing on this. Avatars are behind a SAML on our github enterprise instance.

Fuyucch1 avatar Nov 28 '24 21:11 Fuyucch1

I'm closing this now since I it works when hosted, just didin't work locally.

mihaigalos avatar Nov 29 '24 08:11 mihaigalos