optinist icon indicating copy to clipboard operation
optinist copied to clipboard

Probably unneeded parameters in suite2p_file nodes

Open Miles-and-miles-away opened this issue 2 years ago • 0 comments

追加機能についての概要 suite2p_file_convert

  • do_registration: suite2p_file_convert and suite2p_registration are separate nodes. So we don't need this parameter.

  • keep_movie_raw: I think Optinist always keeps this. Does this option have a meaning? This is necessary for two_step_registration, but we don't give that parameter to users.

  • reg_tif: "whether or not to write the registered binary to tiff files". This also seems an inherent Optinist decision, does the user have access to there?

suite2p_registration

  • functional_chan: This should be moved to suite2p_file_convert.

  • do_bidiphase: This could be set to the same as bidi_corrected. do_bidiphase is only asking whether to do the calculation. However, bidi_corrected decides whether to apply this. For Optinist we only need to do the calculation if we are going to apply it.

Consider also putting bidi_corrected and bidiphase under suite2p_file_convert as these are suite2p "main settings"

  • frames_include: Optinist really needs it's own node to modify the frames/pixels/rows to include in any file type.

  • diameter: This seems to only be used in Cellpose Detection, which is an extended toolbox that I don't think Optinist is using.

suite2p_roi

  • neucoeff: this may only be used in suite2p_spike_deconv. It seems to be a repeated input parameter in both suite2p_roi and suite2p_spike_deconv.

Consider moving tau under suite2p_file_convert as these are suite2p "main settings".

重要度 低: この機能は開発要件の最低条件に含まれていない。

Miles-and-miles-away avatar Dec 12 '23 05:12 Miles-and-miles-away