openid-connect-generic icon indicating copy to clipboard operation
openid-connect-generic copied to clipboard

Fix userinfo request method

Open JUVOJustin opened this issue 1 year ago • 2 comments

All Submissions:

Changes proposed in this Pull Request:

Change the userinfo request method from POST to GET. This is causing issues with some identity providers like cloudflare since the recommended method is GET.

How to test the changes in this Pull Request:

Just test idp´s as usual

Other information:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] Have you written new tests for your changes, as applicable?
  • [x] Have you successfully run tests with your changes locally?

Changelog entry

Changed userinfo endpoint request to GET as this is the recommended method by The OpenID Foundation. Implicitly solves authentication issues with cloudflare zero trust.

JUVOJustin avatar Aug 22 '24 09:08 JUVOJustin

Is there anything I can do to unblock this? It is such a minor patch which would solve OpenID auth especially for users that use cloudflare. Would love to see this in core.

If there is anything i can do to unblock pls let me know.

JUVOJustin avatar Sep 25 '24 12:09 JUVOJustin

At this point in the coming weeks I will be submitting my final patch for this plugin. At which point I'll be looking for new maintainers. I no longer have the energy for WordPress and the toxicity of Matt Mullenweg permeating the WordPress community. If there are no reputable maintainers that step up to take over this plugin then it will more than likely die off.

timnolte avatar Sep 25 '24 12:09 timnolte