openid-connect-generic icon indicating copy to clipboard operation
openid-connect-generic copied to clipboard

Token Response Attribute `expires_in` Should be Optional

Open yogeshbeniwal opened this issue 3 years ago • 1 comments

Describe the bug PHP warning message are shown in server error log with PHP 8.1

Screenshots [error] 41977#41977: *167373 FastCGI sent in stderr: "PHP message: PHP Warning: Undefined array key "expires_in" in /daggerhart-openid-connect-generic/includes/openid-connect-generic-client-wrapper.php on line 700" while reading response header from upstream

yogeshbeniwal avatar Sep 15 '22 02:09 yogeshbeniwal

Just noting that the real issue is that the tokens response expires_in attribute is defined as an optional attribute.

https://openid.net/specs/openid-connect-basic-1_0.html#TokenOK

expires_in OPTIONAL. Expiration time of the Access Token in seconds since the response was generated.

timnolte avatar Sep 15 '22 02:09 timnolte