openid-connect-generic icon indicating copy to clipboard operation
openid-connect-generic copied to clipboard

Adding support for generic front logout channel

Open StarAurryon opened this issue 3 years ago • 2 comments

All Submissions:

Changes proposed in this Pull Request:

Implementing standard OpenID front logout channel as per https://openid.net/specs/openid-connect-frontchannel-1_0.html.

Closes #336 .

How to test the changes in this Pull Request:

  1. Fill the revoke endpoint in the settings of the plugin;
  2. Do a GET on /wp-admin/admin-ajax.php?action=openid-connect-logout&sid=TOKEN_SID&iss=TOKEN_ISS with the browser of a connected user;
  3. The user should be disconnected.

Changelog entry

  • Adding revoke OpenID endpoint in the settings;
  • Adding openid-connect-logout endpoint to perform the front logout (iframe rendered by the client).

StarAurryon avatar Sep 07 '21 12:09 StarAurryon

@StarAurryon also, this PR doesn't pass code quality checks so that also needs to be addressed. Your PR doesn't reference any open issues/feature requests if there are any open issues that pertain to this change they should be referenced in your PR. Thanks!

timnolte avatar Sep 08 '21 00:09 timnolte

My apologies. I was not able to set up the proper testing framework at first (requiring composer 1) and I had to dig a bit further to find what was missing.

Hope this is better now.

StarAurryon avatar Sep 08 '21 16:09 StarAurryon