ohmyzsh icon indicating copy to clipboard operation
ohmyzsh copied to clipboard

fix(nvm): Trim invisible characters from .nvmrc

Open Zeragamba opened this issue 2 years ago • 0 comments

Standards checklist:

  • [x] The PR title is descriptive.
  • [x] The PR doesn't replicate another PR which is already open.
  • [x] I have read the contribution guide and followed all the instructions.
  • [x] The code follows the code style guide detailed in the wiki.
  • [x] The code is mine or it's from somewhere with an MIT-compatible license.
  • [x] The code is efficient, to the best of my ability, and does not waste computer resources.
  • [x] The code is stable and I have tested it myself, to the best of my abilities.

Changes:

Ran into an issue where the nvm autoload would always try to install and use node. Turns out newline characters in my .nvmrc files caused issues with the nvm version check. This PR trims non-printable characters from the .nvmrc file before passing it to nvm.

Zeragamba avatar Jun 16 '22 13:06 Zeragamba